Project

General

Profile

Actions
Copy link

Bug #9170

closed

libnisdb: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    nis_parse_ldap_util.c:2048:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
          if (yp2ldap) {
             ^
    nis_parse_ldap_util.c:2056:5: note: here
         case '{': /* begin sequence */
         ^~~~

    ldap_val.c:1796:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
       ipaddr = TRUE;
    ldap_val.c:1798:2: note: here
      case mmt_item:
      ^~~~

    yptol/dit_access.c:299:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        logmsg(MSG_NOTIMECHECK, LOG_INFO,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        "%s passed illegal TTL type (%d)", myself, type);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    yptol/dit_access.c:303:3: note: here
       case TTL_RAND:
       ^~~~

    nis_parse_ldap_yp_util.c:1106:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
           type = YP_NAME_FIELDS;
    nis_parse_ldap_yp_util.c:1107:6: note: here
          case key_yp_split_field:
          ^~~~

    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 47b593ae804b630db6181b381da50004d50584f9

commit  47b593ae804b630db6181b381da50004d50584f9
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-27T01:43:24.000Z

    9170 libnisdb: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF