Project

General

Profile

Actions
Copy link

Bug #9172

closed

smbsrv/libsmb: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../common/smb_domain.c: In function 'smb_dcache_lock':
    ../common/smb_domain.c:659:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (mode == SMB_DCACHE_RDLOCK) {
          ^
    ../common/smb_domain.c:670:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit bdb589c6ad19f83278e31d9fc3fc604f8182853c

commit  bdb589c6ad19f83278e31d9fc3fc604f8182853c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-27T01:44:58.000Z

    9172 smbsrv/libsmb: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF