Project

General

Profile

Bug #9180

gss_mechs/mech_krb5: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    /code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/krb5/krb/unparse.c:131:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
          if (no_realm) {
             ^
    /code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/krb5/krb/unparse.c:136:2: note: here
      case COMPONENT_SEP:
      ^~~~

    /code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/mech/k5unseal.c:501:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
      code = memcmp(md5cksum.contents, ptr+14, 8);
      ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/mech/k5unseal.c:504:5: note: here
         default:
         ^~~~~~~

    ../krb5/krb/chpw.c:549:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
        *code_string = "Success";
        ~~~~~~~~~~~~~^~~~~~~~~~~
    ../krb5/krb/chpw.c:550:4: note: here
        default:
        ^~~~~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 06307114472bd8aad5ff18ccdb8e25f128ae6652

commit  06307114472bd8aad5ff18ccdb8e25f128ae6652
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-02T23:11:45.000Z

    9180 gss_mechs/mech_krb5: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF