Project

General

Profile

Bug #9181

ipf: this use of "defined" may not be portable

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

        in file included from ../../common/inet/ipf/ip_frag.c:79:0:
        ../../common/inet/ipf/netinet/ip_fil.h:1378:7: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
         #  if SOLARIS
               ^~~~~~~
        ../../common/inet/ipf/netinet/ip_fil.h:1378:7: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
        ../../common/inet/ipf/netinet/ip_fil.h:1378:7: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]

Use explicit value of (1) or (0) and use the same method in all cases.

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit ae7a42b1202d66a3f5538a09de0a28329264fd15

commit  ae7a42b1202d66a3f5538a09de0a28329264fd15
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-01T21:48:01.000Z

    9181 ipf: this use of "defined" may not be portable
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF