Project

General

Profile

Bug #9189

Add debug to vdev_label_read_config when txg check fails

Added by Brad Lewis over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2018-02-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

This changes were added to help debug issue #9187.

Essentially, in the original bug, vdev_validate() seems to fails in vdev_label_read_config() and prints "failed reading config". This could happen because either:
1. The labels are actually corrupt and zio_wait() fails for all of them
2. The labels were discarded because they didn't pass the txg check.

Beyond #9187, having debug info when case 2 happens could be useful in other scenarios, such as zpool import.

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit b6bf6e1540f30bd97b8d6e2c21d95e17841e0f23

commit  b6bf6e1540f30bd97b8d6e2c21d95e17841e0f23
Author: Pavel Zakharov <pavel.zakharov@delphix.com>
Date:   2018-03-21T15:37:35.000Z

    9189 Add debug to vdev_label_read_config when txg check fails
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Prashanth Sreenivasa <pks@delphix.com>
    Approved by: Matt Ahrens <mahrens@delphix.com>

Also available in: Atom PDF