Project

General

Profile

Bug #9204

illumos#8149 introduced deadlock between device detach and kstat read

Added by Yuri Pankov over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ryan Zezeski
Category:
networking
Start date:
2018-02-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

This is to upstream the Joyent's OS-6137 fix as we seem to be hitting the deadlock intermittently:

> > ::stacks -m dls
THREAD           STATE    SOBJ                COUNT
ffffff0011954c40 SLEEP    CV                      1
                 swtch+0x18a
                 cv_wait+0x89
                 kstat_hold+0x4d
                 kstat_hold_bykid+0x37
                 kstat_delete+0x52
                 dls_devnet_stat_destroy+0x59
                 dls_devnet_unset+0x2bd
                 dls_devnet_destroy+0x46
                 softmac_destroy+0x422
                 net_predetach+0x3a
                 dacf_op_invoke+0x26e
                 dacf_process_rsrvs+0x10b
                 dacfc_predetach+0x41
                 predetach_node+0x3b
                 i_ndi_unconfig_node+0x1eb
                 i_ddi_detachchild+0x59
                 devi_detach_node+0xac
                 unconfig_immediate_children+0x1b5
                 devi_unconfig_common+0x107
                 mt_config_thread+0x259
                 thread_start+8

ffffff040c5687e0 SLEEP    CV                      1
                 swtch+0x18a
                 cv_wait+0x89
                 softmac_hold_device+0x203
                 stubs_common_code+0x51
                 dls_devnet_hold_common+0xc5
                 dls_devnet_hold_tmp+0x1a
                 dls_devnet_stat_update+0x2e
                 read_kstat_data+0xd0
                 kstat_ioctl+0x83
                 cdev_ioctl+0x39
                 spec_ioctl+0x60
                 fop_ioctl+0x55
                 ioctl+0x9b
                 _sys_sysenter_post_swapgs+0x234

History

#1

Updated by Yuri Pankov over 1 year ago

  • Subject changed from 8149 introduced deadlock between device detach and kstat read to illumos#8149 introduced deadlock between device detach and kstat read
#2

Updated by Yuri Pankov over 1 year ago

  • Description updated (diff)
#3

Updated by Yuri Pankov over 1 year ago

  • Status changed from In Progress to Pending RTI
  • Assignee changed from Yuri Pankov to Ryan Zezeski
#4

Updated by Electric Monk over 1 year ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 68f58420d17ff3c1ceb1283919a034f00cfba9f6

commit  68f58420d17ff3c1ceb1283919a034f00cfba9f6
Author: Ryan Zezeski <rpz@joyent.com>
Date:   2018-02-26T18:57:35.000Z

    9204 illumos#8149 introduced deadlock between device detach and kstat read
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Bryan Cantrill <bryan@joyent.com>
    Reviewed by: Rick McNeal <rick.mcneal@nexenta.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF