Project

General

Profile

Actions

Bug #9205

closed

illumos-gate build shouldn't depend on demangle.h header

Added by Alexander Pyhalov over 4 years ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Category:
tools - gate/build tools
Start date:
2018-02-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

illumos-gate can't be build without system/library/c++/sunpro package, as it depends on demangle.h header. This dependency should be avoided, as header comes from closed-source package.

Actions #1

Updated by Robert Mustacchi 7 months ago

  • Category set to tools - gate/build tools
  • Status changed from New to Resolved
  • Assignee set to Robert Mustacchi
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)

This is no longer the case. In particular, with the integration of #6375, references to the old <demangle.h> from Studio were removed and if we check the gate now, there are no references to that file any more. A sanity check grep shows:

~/src/illumos-gate/usr/src $ grep -Ri 'demangle.h' *
cmd/mdb/common/mdb/mdb_nm.c:#include <mdb/mdb_demangle.h>
cmd/mdb/common/mdb/mdb.h:#include <mdb/mdb_demangle.h>
cmd/mdb/common/mdb/mdb.h:    mdb_demangler_t *m_demangler; /* Demangler (see <mdb/mdb_demangle.h>) */
cmd/mdb/common/mdb/mdb_demangle.h:#ifndef    _MDB_DEMANGLE_H
cmd/mdb/common/mdb/mdb_demangle.h:#define    _MDB_DEMANGLE_H
cmd/mdb/common/mdb/mdb_demangle.h:#endif    /* _MDB_DEMANGLE_H */
cmd/mdb/common/mdb/mdb_io.c:#include <mdb/mdb_demangle.h>
cmd/mdb/common/mdb/mdb_demangle.c:#include <mdb/mdb_demangle.h>
cmd/mdb/common/mdb/mdb_cmds.c:#include <mdb/mdb_demangle.h>
cmd/mdb/common/kmdb/kmdb_demangle.c:#include <mdb/mdb_demangle.h>
cscope.files:./cmd/mdb/common/mdb/mdb_demangle.h
Binary file cscope.in.out matches
cscope.out:    @cmd/mdb/common/mdb/mdb_demangle.h
cscope.out:_MDB_DEMANGLE_H
cscope.out:    #_MDB_DEMANGLE_H
cscope.out:cmd/mdb/common/mdb/mdb_demangle.h
man/man3ext/demangle.3ext:#include <demangle.h>
Actions

Also available in: Atom PDF