Bug #9218

bge: this statement may fall through

Added by Toomas Soome 12 months ago. Updated 9 months ago.

Status:ClosedStart date:2018-03-01
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:driver - device drivers
Target version:-
Difficulty:Medium Tags:

Description

Issue found by gcc 7:

    ../../common/io/bge/bge_chip2.c:2146:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (bgep->chipid.device == DEVICE_ID_5761)
          ^
    ../../common/io/bge/bge_chip2.c:2148:2: note: here
      case BGE_APE_LOCK_GRC:
      ^~~~
    ../../common/io/bge/bge_chip2.c: In function 'bge_ape_unlock':
    ../../common/io/bge/bge_chip2.c:2207:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (bgep->chipid.device == DEVICE_ID_5761)
          ^
    ../../common/io/bge/bge_chip2.c:2209:2: note: here
      case BGE_APE_LOCK_GRC:
      ^~~~
    cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk 9 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit abfaa596b786488ec4aee4fcc241f6021f04ee50

commit  abfaa596b786488ec4aee4fcc241f6021f04ee50
Author: Toomas Soome <tsoome@me.com>
Date:   2018-05-30T15:09:04.000Z

    9218 bge: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom