Project

General

Profile

Bug #9221

cpqary3: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-11
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Difficulty:
Bite-size
Tags:

Description

Issue found by gcc 7 build:

    ../../common/io/cpqary3/cpqary3_transport.c:481:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       cmn_err(CE_PANIC, "CPQary3: Another I/O transaction " 
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           "is using the DMA handle");
           ~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../common/io/cpqary3/cpqary3_transport.c:484:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors


Subtasks

Bug #9261: cpqary3: wrong value is used in panic messageClosedToomas Soome

Actions

History

#1

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed

git commit 59e9026779cf4a22e08153f0b7702f8167fb44c7

commit  59e9026779cf4a22e08153f0b7702f8167fb44c7
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:38.000Z

    9221 cpqary3: this statement may fall through
    9261 cpqary3: wrong value is used in panic message
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF