Project

General

Profile

Bug #9226

fd: this statement may fall through

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../../common/io/fd.c:375:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (cmos)
           ^
    ../../common/io/fd.c:384:3: note: here
       default:  /* need to check .conf file */
       ^~~~~~~
    ../../common/io/fd.c: In function 'fd_probe':
    ../../common/io/fd.c:298:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (cmos && (drive_type & 0x0F)) {
          ^
    ../../common/io/fd.c:308:2: note: here
      default:  /* need to check conf file */
      ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk almost 2 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit eea675a170a637d45397e62f4efc44be56b572a3

commit  eea675a170a637d45397e62f4efc44be56b572a3
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-11T06:15:40.000Z

    9226 fd: this statement may fall through
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF