Project

General

Profile

Actions

Bug #9232

closed

mega_sas: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../../common/io/mega_sas/megaraid_sas.c: In function 'build_cmd':
    ../../common/io/mega_sas/megaraid_sas.c:3369:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (acmd->islogical) {
          ^
    ../../common/io/mega_sas/megaraid_sas.c:3452:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2811ec437a3102acd185cc6fafc9a716169cac2a

commit  2811ec437a3102acd185cc6fafc9a716169cac2a
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:38.000Z

    9232 mega_sas: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions

Also available in: Atom PDF