Project

General

Profile

Bug #9237

"zpool add" fails for very large pools

Added by Alan Somers about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2018-03-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

8567 changed the return value of zpool_read_label. Error paths that previously returned 0 began to return -1 instead. However, not all error paths initialized errno. When adding vdevs to a very large pool, errno could be prepopulated with ENOMEM, causing the operation to fail. Fix the bug by setting errno=ENOENT in the case that no ZFS label is found.

First reported at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226096 .

#1

Updated by Electric Monk almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ae5ee1bd5e54409b4589217b160c8cf4b81e2fb8

commit  ae5ee1bd5e54409b4589217b160c8cf4b81e2fb8
Author: Alan Somers <asomers@gmail.com>
Date:   2018-05-01T19:59:28.000Z

    9237 "zpool add" fails for very large pools
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Andriy Gapon <avg@FreeBSD.org>
    Approved by: Matt Ahrens <mahrens@delphix.com>

Also available in: Atom PDF