Project

General

Profile

Actions
Copy link

Bug #9239

closed

mr_sas: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2018-03-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../../common/io/mr_sas/mr_sas.c: In function 'build_cmd':
    ../../common/io/mr_sas/mr_sas.c:5132:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (acmd->islogical) {
          ^
    ../../common/io/mr_sas/mr_sas.c:5228:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit de6ecd7f43e1627e7b738535c187ace8c2fd8f85

commit  de6ecd7f43e1627e7b738535c187ace8c2fd8f85
Author: Toomas Soome <tsoome@me.com>
Date:   2018-05-14T14:53:24.000Z

    9239 mr_sas: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF