Project

General

Profile

Bug #9242

st: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

issue found by gcc 7 build:

    ../../common/io/scsi/targets/st.c:18498:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
         reset_type = RESET_ALL;
    ../../common/io/scsi/targets/st.c:18499:4: note: here
        default:
        ^~~~~~~
    ../../common/io/scsi/targets/st.c: In function 'st_decode_sense':
    ../../common/io/scsi/targets/st.c:11207:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
         if (ri->pkt_retry_cnt++ < st_retry_count) {
            ^
    ../../common/io/scsi/targets/st.c:11212:4: note: here
        default: /* FALLTHRU */
        ^~~~~~~
    ../../common/io/scsi/targets/st.c: In function 'st_set_state':
    ../../common/io/scsi/targets/st.c:12040:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (new_lastop != ST_OP_NIL) {
           ^
    ../../common/io/scsi/targets/st.c:12043:3: note: here
       default:
       ^~~~~~~
    ../../common/io/scsi/targets/st.c: In function 'st_modesense':
    ../../common/io/scsi/targets/st.c:8164:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (un->un_dp->options & ST_MODE_SEL_COMP) {
          ^
    ../../common/io/scsi/targets/st.c:8185:2: note: here
      default: /* FALLTHROUGH */
      ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 11 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 3b5ccf6b95a705120c7f7fa193afabfd40dc7342

commit  3b5ccf6b95a705120c7f7fa193afabfd40dc7342
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-16T16:26:36.000Z

    9242 st: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF