Project

General

Profile

Bug #9265

e1000g: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../../common/io/e1000api/e1000_82575.c:1681:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
       pcs_autoneg = FALSE;
    ../../common/io/e1000api/e1000_82575.c:1683:2: note: here
      default:
      ^~~~~~~
    ../../common/io/e1000api/e1000_82575.c: In function 'e1000_get_media_type_82575':
    ../../common/io/e1000api/e1000_82575.c:1803:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (e1000_sgmii_uses_mdio_82575(hw)) {
          ^
    ../../common/io/e1000api/e1000_82575.c:1809:2: note: here
      case E1000_CTRL_EXT_LINK_MODE_PCIE_SERDES:
      ^~~~

    ../../common/io/e1000api/e1000_phy.c: In function 'e1000_copper_link_setup_m88_gen2':
    ../../common/io/e1000api/e1000_phy.c:1296:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (phy->id != M88E1112_E_PHY_ID) {
          ^
    ../../common/io/e1000api/e1000_phy.c:1300:2: note: here
      case 0:
      ^~~~

    ../../common/io/e1000api/e1000_vf.c:489:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
       msgbuf |= E1000_VF_SET_PROMISC_MULTICAST;
    ../../common/io/e1000api/e1000_vf.c:490:2: note: here
      case e1000_promisc_unicast:
      ^~~~

    ../../common/io/e1000api/e1000_mbx.c: In function 'e1000_init_mbx_params_pf':
    ../../common/io/e1000api/e1000_mbx.c:780:19: error: this statement may fall through [-Werror=implicit-fallthrough=]
       mbx->stats.rsts = 0;
       ~~~~~~~~~~~~~~~~^~~
    ../../common/io/e1000api/e1000_mbx.c:781:2: note: here
      default:
      ^~~~~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 5e832498d1743a9c84b5f53b983c9f469290b34b

commit  5e832498d1743a9c84b5f53b983c9f469290b34b
Author: Toomas Soome <tsoome@me.com>
Date:   2018-05-31T22:59:44.000Z

    9265 e1000g: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF