Project

General

Profile

Bug #9266

ixgbe: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../../common/io/ixgbe/core/ixgbe_common.c:250:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (ret_val != IXGBE_SUCCESS)
          ^
    ../../common/io/ixgbe/core/ixgbe_common.c:254:2: note: here
      case ixgbe_media_type_fiber_fixed:
      ^~~~
    ../../common/io/ixgbe/core/ixgbe_common.c: In function 'ixgbe_set_rxpba_generic':
    ../../common/io/ixgbe/core/ixgbe_common.c:4566:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       for (; i < (num_pb / 2); i++)
       ^~~
    ../../common/io/ixgbe/core/ixgbe_common.c:4569:2: note: here
      case PBA_STRATEGY_EQUAL:
      ^~~~

    ../../common/io/ixgbe/core/ixgbe_82599.c:1742:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
       fdirm |= IXGBE_FDIRM_VLANID;
    ../../common/io/ixgbe/core/ixgbe_82599.c:1743:2: note: here
      case 0x0FFF:
      ^~~~
    ../../common/io/ixgbe/core/ixgbe_82599.c: In function 'ixgbe_fdir_add_perfect_filter_82599':
    ../../common/io/ixgbe/core/ixgbe_82599.c:2012:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (input->formatted.dst_port || input->formatted.src_port) {
          ^
    ../../common/io/ixgbe/core/ixgbe_82599.c:2016:2: note: here
      case IXGBE_ATR_FLOW_TYPE_TCPV4:
      ^~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit e5c421abb8bd517cb6964747b9ce23066e1a1cef

commit  e5c421abb8bd517cb6964747b9ce23066e1a1cef
Author: Toomas Soome <tsoome@me.com>
Date:   2018-07-30T20:20:34.000Z

    9266 ixgbe: this statement may fall through
    Reviewed by: Andy Fiddaman <af@citrus-it.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF