Project

General

Profile

Bug #9267

ufs: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
filesystems (not ZFS)
Start date:
2018-03-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../../common/fs/ufs/ufs_panic.c: In function 'ufs_fault_v':
    ../../common/fs/ufs/ufs_panic.c:492:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (!(DEBUG_FLAGS & DBGFLG_FIXWOULDPANIC)) {
          ^
    ../../common/fs/ufs/ufs_panic.c:502:2: note: here
      case TRIAGE_ATTEND_TO:
      ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 645a7badb6d38db4d4e2040b6e5ccfbcdf9e7f85

commit  645a7badb6d38db4d4e2040b6e5ccfbcdf9e7f85
Author: Toomas Soome <tsoome@me.com>
Date:   2018-06-25T20:26:20.000Z

    9267 ufs: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF