Bug #9268

cxgbe: this statement may fall through

Added by Toomas Soome 12 months ago. Updated 8 months ago.

Status:ClosedStart date:2018-03-12
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:driver - device drivers
Target version:-
Difficulty:Bite-size Tags:

Description

Issue found by gcc 7 build:

    ../../../common/io/cxgbe/t4nex/t4_sge.c: In function 't4_ring_rx':
    ../../../common/io/cxgbe/t4nex/t4_sge.c:812:7: error: this statement may fall th
    rough [-Werror=implicit-fallthrough=]
        if (m == NULL) {
           ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:817:3: note: here
       case X_RSPD_TYPE_CPL:
       ^~~~
    cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk 8 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4

commit  4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4
Author: Toomas Soome <tsoome@me.com>
Date:   2018-06-25T20:26:44.000Z

    9268 cxgbe: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom