Project

General

Profile

Actions

Bug #9269

closed

uts/i86pc: rootnex comparison between pointer and zero character constant

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-03-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../../i86pc/io/immu_dmar.c:929:24: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
            ((char *)strptr == '\0' ||
                            ^~
    ../../i86pc/io/immu_dmar.c:929:9: note: did you mean to dereference the pointer?
            ((char *)strptr == '\0' ||
             ^
    ../../i86pc/io/immu_dmar.c:931:24: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
            ((char *)strptr == '\0' ||
                            ^~
    ../../i86pc/io/immu_dmar.c:931:9: note: did you mean to dereference the pointer?
            ((char *)strptr == '\0' ||
             ^

    ../../i86pc/io/immu.c:694:24: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
            ((char *)strptr == '\0' ||
                            ^~
    ../../i86pc/io/immu.c:694:9: note: did you mean to dereference the pointer?
            ((char *)strptr == '\0' ||
             ^
    ../../i86pc/io/immu.c:696:24: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
            ((char *)strptr == '\0' ||
                            ^~
    ../../i86pc/io/immu.c:696:9: note: did you mean to dereference the pointer?
            ((char *)strptr == '\0' ||
             ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 243bebc0df1221801f517d667fdace1c1aeb94c1

commit  243bebc0df1221801f517d667fdace1c1aeb94c1
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-23T14:45:25.000Z

    9269 uts/i86pc: rootnex comparison between pointer and zero character constant
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF