Project

General

Profile

Bug #9295

ifconfig: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
2018-03-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Issue found by gcc7 build:

    ifconfig.c: In function 'start_ipmp_daemon':
    ifconfig.c:3793:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       Perror0_exit("start_ipmp_daemon: fork");
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ifconfig.c:3795:2: note: here
      case 0:
      ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit f13c98b88c56dc9f2501130dd749358863c0e4e9

commit  f13c98b88c56dc9f2501130dd749358863c0e4e9
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-25T17:30:16.000Z

    9295 ifconfig: this statement may fall through
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.net>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF