Project

General

Profile

Bug #9303

chat: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

issue found by gcc 7 build:

    chat.c:1214:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
      logf("warning: read() on stdin returned %d", status);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    chat.c:1216:5: note: here
         case -1:
         ^~~~
    chat.c: In function 'put_char':
    chat.c:1242:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
      logf("warning: write() on stdout returned %d", status);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    chat.c:1244:5: note: here
         case -1:
         ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit b2cf51950f94dd7f59fa3a283f96a19a31858b25

commit  b2cf51950f94dd7f59fa3a283f96a19a31858b25
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-25T18:16:17.000Z

    9303 chat: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF