Project

General

Profile

Actions

Bug #9304

closed

ftp: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

    cmds.c: In function 'domap':
    cmds.c:1911:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (*cp2 >= '1' && *cp2 <= '9') {
           ^
    cmds.c:1942:3: note: here
       default:
       ^~~~~~~
    cmds.c:2057:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (isdigit(*(cp2 + 1))) {
           ^
    cmds.c:2075:3: note: here
       default:
       ^~~~~~~

    domacro.c:117:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
         if (*(cp1+1) == 'i') {
            ^
    domacro.c:127:4: note: here
        default:
        ^~~~~~~

    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c2b69dec36507b9e29407d1fcc61adc12e08492b

commit  c2b69dec36507b9e29407d1fcc61adc12e08492b
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-25T18:16:18.000Z

    9304 ftp: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF