Project

General

Profile

Bug #9305

pppdump: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

issue found by gcc 7 build:

    zlib.c:2886:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = FLAG;
           ~~~~~~~~~~~~~~~^~~~~~
    zlib.c:2887:5: note: here
         case FLAG:
         ^~~~
    zlib.c:2904:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = BLOCKS;
           ~~~~~~~~~~~~~~~^~~~~~~~
    zlib.c:2905:5: note: here
         case BLOCKS:
         ^~~~
    zlib.c:2924:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = CHECK4;
           ~~~~~~~~~~~~~~~^~~~~~~~
    zlib.c:2925:5: note: here
         case CHECK4:
         ^~~~
    zlib.c:2928:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = CHECK3;
           ~~~~~~~~~~~~~~~^~~~~~~~
    zlib.c:2929:5: note: here
         case CHECK3:
         ^~~~
    zlib.c:2932:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = CHECK2;
           ~~~~~~~~~~~~~~~^~~~~~~~
    zlib.c:2933:5: note: here
         case CHECK2:
         ^~~~
    zlib.c:2936:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = CHECK1;
           ~~~~~~~~~~~~~~~^~~~~~~~
    zlib.c:2937:5: note: here
         case CHECK1:
         ^~~~
    zlib.c:2949:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           z->state->mode = DONE;
           ~~~~~~~~~~~~~~~^~~~~~
    zlib.c:2950:5: note: here
         case DONE:
         ^~~~
    zlib.c: In function 'inflate_blocks':
    zlib.c:3476:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           s->mode = CODES;
           ~~~~~~~~^~~~~~~
    zlib.c:3477:5: note: here
         case CODES:
         ^~~~
    zlib.c:3501:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           s->mode = DRY;
           ~~~~~~~~^~~~~
    zlib.c:3502:5: note: here
         case DRY:
         ^~~~
    zlib.c:3506:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           s->mode = DONEB;
           ~~~~~~~~^~~~~~~
    zlib.c:3507:5: note: here
         case DONEB:
         ^~~~
    zlib.c: In function 'inflate_codes':
    zlib.c:4182:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           c->mode = LEN;
           ~~~~~~~~^~~~~
    zlib.c:4183:5: note: here
         case LEN:           /* i: get length/literal/eob next */
         ^~~~
    zlib.c:4229:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           c->mode = DIST;
           ~~~~~~~~^~~~~~
    zlib.c:4230:5: note: here
         case DIST:          /* i: get distance next */
         ^~~~
    zlib.c:4259:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           c->mode = COPY;
           ~~~~~~~~^~~~~~
    zlib.c:4260:5: note: here
         case COPY:          /* o: copying bytes in window, waiting for space */
         ^~~~
    zlib.c:4289:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
           c->mode = END;
           ~~~~~~~~^~~~~
    zlib.c:4290:5: note: here
         case END:
         ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 5b85b345b049f7f7544f27a5b5e2b1bfa91da91e

commit  5b85b345b049f7f7544f27a5b5e2b1bfa91da91e
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-01T21:48:01.000Z

    9305 pppdump: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF