Project

General

Profile

Actions

Bug #9306

closed

pppd: this use of "defined" may not be portable

Added by Toomas Soome over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

    ipcp.c: In function 'ipcp_up':
    ipcp.c:1546:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if SIFUPFIRST
         ^~~~~~~~~~
    ipcp.c:1546:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipcp.c:1546:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipcp.c:1561:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if !SIFUPFIRST
          ^~~~~~~~~~
    ipcp.c:1561:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipcp.c:1561:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]

    ipv6cp.c:1110:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if SIF6UPFIRST
         ^~~~~~~~~~~
    ipv6cp.c:1110:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1110:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1110:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1116:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if !SIF6UPFIRST
          ^~~~~~~~~~~
    ipv6cp.c:1116:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1116:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1116:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c: In function 'ipv6cp_up':
    ipv6cp.c:1212:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if !SIF6UPFIRST
          ^~~~~~~~~~~
    ipv6cp.c:1212:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1212:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1212:6: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1236:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
     #if SIF6UPFIRST
         ^~~~~~~~~~~
    ipv6cp.c:1236:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1236:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]
    ipv6cp.c:1236:5: error: this use of "defined" may not be portable [-Werror=expansion-to-defined]

    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f6b0cb17c5dc44ae872c22ebbbd2663c98723311

commit  f6b0cb17c5dc44ae872c22ebbbd2663c98723311
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-01T21:48:01.000Z

    9306 pppd: this use of "defined" may not be portable
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF