Project

General

Profile

Bug #9307

rdist: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

issue found by gcc 7 build:

    server.c:220:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        error("server: unknown command '%s'\n", cp);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    server.c:221:3: note: here
       case '\0':
       ^~~~
    server.c: In function 'response':
    server.c:1621:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
       s--;
       ~^~
    server.c:1623:2: note: here
      case '\1':
      ^~~~

    gram.y:206:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (c == EOF)
          ^
    gram.y:208:2: note: here
      case '\n':
      ^~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit c15ff06a5cef5880e0afc02c7a87c6b22455f848

commit  c15ff06a5cef5880e0afc02c7a87c6b22455f848
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-01T21:48:01.000Z

    9307 rdist: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF