Project

General

Profile

Bug #9364

genunix: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2018-03-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

issues found by gcc 7 build:

    ../../common/inet/sctp/sctp_conn.c: In function 'sctp_connect':
    ../../common/inet/sctp/sctp_conn.c:474:19: error: this statement may fall th
rough [-Werror=implicit-fallthrough=]
      case SCTPS_IDLE: {
                       ^
    ../../common/inet/sctp/sctp_conn.c:499:2: note: here
      case SCTPS_BOUND:
      ^~~~

    ../../common/inet/ip/ip_output.c: In function 'conn_ip_output':
    ../../common/inet/ip/ip_output.c:238:17: error: this statement may fall thro
ugh [-Werror=implicit-fallthrough=]
       case ENOTSUP: { /* ZEROCOPY */
                     ^
    ../../common/inet/ip/ip_output.c:249:3: note: here
       default:
       ^~~~~~~

    ../../common/inet/ip/ip.c: In function 'icmp_inbound_error_fanout_v4':
    ../../common/inet/ip/ip.c:2218:22: error: this statement may fall through [-
Werror=implicit-fallthrough=]
      case IPPROTO_ENCAP: {
                          ^
    ../../common/inet/ip/ip.c:2288:2: note: here
      case IPPROTO_IPV6:
      ^~~~

    ../../common/inet/ip/ip6.c: In function 'icmp_inbound_error_fanout_v6':
    ../../common/inet/ip/ip6.c:905:21: error: this statement may fall through [-
Werror=implicit-fallthrough=]
      case IPPROTO_IPV6: {
                         ^
    ../../common/inet/ip/ip6.c:967:2: note: here
      case IPPROTO_ENCAP:
      ^~~~

    ../../common/syscall/uadmin.c: In function 'kadmin':
    ../../common/syscall/uadmin.c:298:13: error: this statement may fall through
 [-Werror=implicit-fallthrough=]
       invoke_cb = B_TRUE;
       ~~~~~~~~~~^~~~~~~~
    ../../common/syscall/uadmin.c:303:2: note: here
      case A_REBOOT:
      ^~~~

    ../../common/fs/fdbuffer.c: In function 'fdb_zero_holes':
    ../../common/fs/fdbuffer.c:327:9: error: this statement may fall through [-W
error=implicit-fallthrough=]
       while (fdh) {
             ^
    ../../common/fs/fdbuffer.c:335:2: note: here
      default:
      ^~~~~~~

    ../../common/syscall/auditsys.c: In function 'auditsys':
    ../../common/syscall/auditsys.c:78:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (audit_active == C2AUDIT_LOADED) {
          ^
    ../../common/syscall/auditsys.c:82:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit a9f62b1aced7d116b939867a588cdf126118cd9a

commit  a9f62b1aced7d116b939867a588cdf126118cd9a
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-06T19:54:37.000Z

    9364 genunix: this statement may fall through
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF