Project

General

Profile

Actions

Bug #9367

closed

troff: comparison between pointer and zero character constant

Added by Toomas Soome over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

    ../n1.c: In function 'main':
    ../n1.c:148:17: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
         if (argv[0] != '\0') {
                     ^~
    ../n1.c:148:9: note: did you mean to dereference the pointer?
         if (argv[0] != '\0') {
             ^
    ../n1.c:184:20: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
        if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0')
                        ^~
    ../n1.c:184:8: note: did you mean to dereference the pointer?
        if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0')
            ^
    ../n1.c:184:71: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
        if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0')
                                                                           ^~
    ../n1.c:184:59: note: did you mean to dereference the pointer?
        if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0')
                                                               ^
    ../n1.c:201:28: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
        if (getenv("TROFFMACS") != '\0') {
                                ^~
    ../n1.c:201:8: note: did you mean to dereference the pointer?
        if (getenv("TROFFMACS") != '\0') {
            ^
    cc1: all warnings being treated as errors

For testing, i have used this doc to learn about register use:

https://www.gnu.org/software/groff/manual/html_node/Setting-Registers.html

So I did call:

nroff -ra2 -man ypwhich.1 | less

And I did add \na just after DESCRIPTION, so the expected outcome was to have ‘2’ printed after the description — and indeed, it was there:

     ypwhich -x

DESCRIPTION
     2

The register ‘a’ was created, set to have a value and was usable.

Actions

Also available in: Atom PDF