Project

General

Profile

Bug #9368

tsol: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

issue found by gcc7 build:

    updatehome.c:140:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        (void) fprintf(stderr, gettext("Bad option -%c.\n"),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            (char)optopt);
            ~~~~~~~~~~~~~
    updatehome.c:143:3: note: here
       default:
       ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit a8337c624edfd3b96a53349fa26a00e19eed2e6c

commit  a8337c624edfd3b96a53349fa26a00e19eed2e6c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-06T19:43:25.000Z

    9368 tsol: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF