Project

General

Profile

Bug #9372

tcpd: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

issue discovered by gcc 7 build:

    safe_finger.c: In function 'pipe_stdin':
    safe_finger.c:178:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
      perror_exit("fork");
      ^~~~~~~~~~~~~~~~~~~
    safe_finger.c:180:5: note: here
         case 0:     /* child */
         ^~~~
    safe_finger.c:187:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
      perror_exit(argv[0]);
      ^~~~~~~~~~~~~~~~~~~~
    safe_finger.c:189:5: note: here
         default:     /* parent */
         ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 11d7f7ff53e371b4622d8a4e0dd50b0e96ac0475

commit  11d7f7ff53e371b4622d8a4e0dd50b0e96ac0475
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-06T19:44:06.000Z

    9372 tcpd: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF