Project

General

Profile

Actions

Bug #9379

closed

pr: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

    pr.c:1056:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
         chars += move;
         ~~~~~~^~~~~~~
    pr.c:1058:4: note: here
        default:
        ^~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3d19b30e50b972b09ded7f37b8a5fc36d10588e6

commit  3d19b30e50b972b09ded7f37b8a5fc36d10588e6
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:40.000Z

    9379 pr: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF