Project

General

Profile

Actions
Copy link

Bug #9380

closed

fm: this statement may fall through

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

issues found by gcc 7 build:

    eval.c:1698:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       out(O_ALTFP|O_DIE, "eval_expr: wrong context for operation %s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           ptree_nodetype2str(np->t));
           ~~~~~~~~~~~~~~~~~~~~~~~~~~
    eval.c:1702:2: note: here
      case T_NE:
      ^~~~

    ../common/escmain.c:166:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        out(O_DIE|O_USAGE, "%s\n%s", Usage, Help);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../common/escmain.c:169:3: note: here
       case 'o':
       ^~~~

    ../common/eftinfo.c:162:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        out(O_DIE|O_USAGE, "%s\n%s", Usage, Help);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../common/eftinfo.c:165:3: note: here
       case 'p':
       ^~~~

    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 586c519ffb95ef510154cdd7c57797c0fecb0434

commit  586c519ffb95ef510154cdd7c57797c0fecb0434
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-06T19:44:38.000Z

    9380 fm: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF