Project

General

Profile

Bug #9381

policykit: this statement may fall through

Added by Toomas Soome over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

    polkit-is-privileged.c: In function 'main':
    polkit-is-privileged.c:183:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       g_print ("Not privileged.\n");
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    polkit-is-privileged.c:185:2: note: here
      case LIBPOLKIT_RESULT_NO_SUCH_PRIVILEGE:
      ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 2 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit f7c0c795f2c4c2b54557114ac4a889b7b14ae45c

commit  f7c0c795f2c4c2b54557114ac4a889b7b14ae45c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-06T19:44:52.000Z

    9381 policykit: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF