Project

General

Profile

Actions
Copy link

Bug #9385

closed

more: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

issue found by gcc 7 build:

more.c:1063:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
             end_it(0);
             ^~~~~~~~~
more.c:1065:9: note: here
         case 's':
         ^~~~
more.c:1170:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
             if (!no_intty) {
                ^
more.c:1178:9: note: here
         default:
         ^~~~~~~
more.c: In function 'colon':
more.c:1250:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 end_it(0);
                 ^~~~~~~~~
more.c:1251:9: note: here
         default:
         ^~~~~~~
more.c: In function 'expand':
more.c:1701:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
             if (*in_str == '%' || *in_str == '!') {
                ^
more.c:1705:9: note: here
         default:
         ^~~~~~~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e608d74df721554c5a0664ff0073a9595af04fac

commit  e608d74df721554c5a0664ff0073a9595af04fac
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:39.000Z

    9385 more: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions
Copy link

Also available in: Atom PDF