Project

General

Profile

Bug #9390

killall: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

issue found by gcc 7 build:

    killall.c:56:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (str2sig(argv[1], &sig) == 0)
           ^
    killall.c:58:3: note: here
       default:
       ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit b3863623bad65c4d98e8af1ef92ca8748dc4396b

commit  b3863623bad65c4d98e8af1ef92ca8748dc4396b
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:39.000Z

    9390 killall: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF