Project

General

Profile

Bug #9414

scsa1394: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

issue found by gcc 7 build:

    ../../common/io/1394/targets/scsa1394/hba.c: In function 'scsa1394_cmd_fake_comp':
    ../../common/io/1394/targets/scsa1394/hba.c:2375:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (!lp->l_mode_sense_fake) {
          ^
    ../../common/io/1394/targets/scsa1394/hba.c:2381:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 0ae3c1c128212f440f395f5f1e70577eada7ca85

commit  0ae3c1c128212f440f395f5f1e70577eada7ca85
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-23T16:15:40.000Z

    9414 scsa1394: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF