Project

General

Profile

Actions
Copy link

Feature #9420

closed

need GCC options to disable function cloning

Added by Toomas Soome about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
tools - gate/build tools
Start date:
2018-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Work done by Richard Lowe. The idea has been circled around before...

Actions
Copy link
 #1

Updated by John Levon over 2 years ago

  • Subject changed from Makefile.master: introduce GCCNEXT to guard options gcc 4 doesn't understand to need GCC options to disable function cloning
  • Assignee changed from Toomas Soome to John Levon

For newer GCCs, we need to specify -fno-clone-functions and -fno-ipa-icf as part of Makefile.master's
CCNOAUTOINLINE

These options prevent GCC from making copies of functions, and removing identical functions, so dtrace and friends can still find them as expected.

Because GCC4 doesn't understand them, we need to specify them as _gcc6=... etc.

Actions
Copy link
 #2

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6b544f0e850631b170bc4e905cf726275acfd586

commit  6b544f0e850631b170bc4e905cf726275acfd586
Author: John Levon <john.levon@joyent.com>
Date:   2018-10-09T15:20:47.000Z

    9420 need GCC options to disable function cloning
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF