Project

General

Profile

Bug #9421

zdb should detect and print out the number of "leaked" objects

Added by Brad Lewis over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2018-03-29
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Difficulty:
Medium
Tags:
needs-triage

Description

As seen in ESCL-144, it is possible for zfs to "leak" objects in such a way that they are not freed, but are also not accessible via the POSIX interface. As the only way to know that this is happened is to see one of them directly in a zdb run, or by noting unaccounted space usage, zdb should be enhanced to count these objects and return failure if some are detected.

We have access to the delete queue through the zfs_get_deleteq function; we should call it in dump_znode to determine if the object is on the delete queue. This is not the most efficient possible method, but it is the simplest to implement, and should suffice for the common case where there few objects on the delete queue.


Subtasks

Bug #9422: zfs diff and zdb should explicitly mark objects that are on the deleted queueClosed

Actions

Related issues

Related to illumos gate - Bug #9559: zfs diff handles files on delete queue in fromsnap poorlyClosed2018-05-29

Actions

History

#1

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed

git commit 20b5dafb425396adaebd0267d29e1026fc4dc413

commit  20b5dafb425396adaebd0267d29e1026fc4dc413
Author: Paul Dagnelie <pcd@delphix.com>
Date:   2018-05-01T19:59:06.000Z

    9421 zdb should detect and print out the number of "leaked" objects
    9422 zfs diff and zdb should explicitly mark objects that are on the deleted queue
    Reviewed by: Matt Ahrens <matt@delphix.com>
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Approved by: Matt Ahrens <mahrens@delphix.com>

#2

Updated by Joshua M. Clulow 9 months ago

  • Related to Bug #9559: zfs diff handles files on delete queue in fromsnap poorly added

Also available in: Atom PDF