Project

General

Profile

Feature #9472

Add smbutil discon command

Added by Gordon Ross over 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2018-04-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

The SMB client tests need a way to get rid of existing connections owned by the user running the tests.
(The tests used to kill the smbiod but that can cause the service to go into maintenance).
We already have driver support to do this, and just need to expose it in a command.
This adds an smbutil "discon" sub-command, primarily for use in the tests.

A related fix to do as part of this, because we're calling smb_iod_disconnect via this sub-command.
No longer tsignal() the IOD thread in smb_iod_disconnect because that ends up being seen in smbiod and can cause it to go into maintenance.
That was always just unnecessary paranoia anyway. Sending a disconnect down the TCP transport is entirely sufficient to cause the IOD thread to terminate.

History

#1

Updated by Electric Monk 9 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit a6d101109bfb442cf0db6d8ebb5fb7c32cb16d7e

commit  a6d101109bfb442cf0db6d8ebb5fb7c32cb16d7e
Author: Gordon Ross <gwr@nexenta.com>
Date:   2018-10-14T14:47:35.000Z

    9472 Add smbutil discon command
    Reviewed by: Matt Barden <matt.barden@nexenta.com>
    Reviewed by: Evan Layton <evan.layton@nexenta.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Ken Mays <kmays2000@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF