Bug #9473

Want git nits to check for white space nits

Added by Gordon Ross 10 months ago. Updated 10 months ago.

Status:ClosedStart date:2018-04-14
Priority:NormalDue date:
Assignee:Gordon Ross% Done:

100%

Category:-
Target version:-
Difficulty:Medium Tags:needs-triage

Description

I got tired of only seeing white space nits after posting a diff in reviewboard, so I added a check to "git nits" and "git pbchk".

+ usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk -b HEAD^
Comments:
These comments are not valid bugs:
  Add white space checks to git nits, git pbchk

white space nits:
usr/src/tools/scripts/git-pbchk.py:126: has trailing spaces
usr/src/tools/scripts/Makefile:163: has trailing spaces
usr/src/tools/scripts/Makefile:175: has trailing spaces
usr/src/tools/onbld/Checks/Makefile:52: space tab sequences


Related issues

Related to illumos gate - Bug #8041: cstyle: space followed by a tab is always bad In Progress 2017-05-14

History

#1 Updated by Marcel Telka 10 months ago

  • Related to Bug #8041: cstyle: space followed by a tab is always bad added

#2 Updated by Electric Monk 10 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 4ff15898b7da74f6c007b0fef82a27cb866afade

commit  4ff15898b7da74f6c007b0fef82a27cb866afade
Author: Gordon Ross <gordon.w.ross@gmail.com>
Date:   2018-05-03T05:03:02.000Z

    9473 Want git nits to check for white space nits
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom