Project

General

Profile

Bug #9479

fix wrong format specifier for vdev_id

Added by Andriy Gapon over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2018-04-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

vdev_dbgmsg_print_tree prints vdev_id that has uint64_t type with %u format specifier.
That causes subsequent parameters to be incorrectly read from the stack (with a 4 byte skew) and that can lead to a crash when a wrong value gets interpreted as a string pointer (for %s format specifier).
Observed on FreeBSD, not confirmed on illumos yet.

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit c7a7b2fa084facd68c3d1e860dfabe20c713877b

commit  c7a7b2fa084facd68c3d1e860dfabe20c713877b
Author: Andriy Gapon <avg@FreeBSD.org>
Date:   2018-06-01T16:22:51.000Z

    9479 fix wrong format specifier for vdev_id
    Reviewed by: Matt Ahrens <matt@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF