Project

General

Profile

Actions

Feature #9502

closed

expose thresholds as properties on sensor facility nodes

Added by Rob Johnston over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2018-04-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

For sensors that expose an analog reading it would be nice, from an observability point of view, if the upper and lower thresholds (if set) were exposed as properties on the corresponding sensor facility node in the hc-scheme topo tree.

Note that this change has already been integrated into illumos-joyent via the following commit:

https://github.com/joyent/illumos-joyent/commit/414afefe58a0a3292d2689bd10360ebb4b505ca6


Related issues

Related to illumos gate - Bug #14720: fac_prov_ipmi: missing thresholds should not be considered errorResolvedYuri Pankov

Actions
Actions #1

Updated by Rob Johnston over 4 years ago

See the original smartos bug report for testing notes:

https://smartos.org/bugview/OS-6732

Actions #2

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 208e1562df6d45a86b71f40db0028ada4de4b56a

commit  208e1562df6d45a86b71f40db0028ada4de4b56a
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   2018-05-14T16:33:15.000Z

    9502 expose thresholds as properties on sensor facility nodes
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Dale Ghent <dale.ghent@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions #3

Updated by Yuri Pankov 4 months ago

  • Related to Bug #14720: fac_prov_ipmi: missing thresholds should not be considered error added
Actions

Also available in: Atom PDF