Project

General

Profile

Bug #9510

usr/src/lib/fm is missing a dependency on libpcidb

Added by Jason King over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-04-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Upstream of Joyent OS-6891 (also present in illumos-gate):

While building SmartOS on my new server, it failed building usr/src/lib/fm because it couldn't link to libpcidb. Looking at it, a bunch of the subdirs all link against it:

find . -name Makefile\* | xargs grep pcidb
./topo/modules/i86pc/pcibus/Makefile:LDLIBS += -ldevinfo -lsmbios -lpcidb
./topo/modules/i86pc/hostbridge/Makefile:LDLIBS += -ldevinfo -lsmbios -lpcidb
./topo/modules/i86pc/x86pi/Makefile:LDLIBS += -lsmbios -ldevinfo -luutil -lpcidb
./topo/modules/sun4/pcibus/Makefile.pci:LDLIBS += -ldevinfo -lsmbios -lpcidb
./topo/modules/sun4/ioboard/Makefile.iob:LDLIBS += -ldevinfo -lsmbios -lpcidb
./topo/modules/sun4/hostbridge/Makefile.hb:LDLIBS += -ldevinfo -lsmbios -lpcidb
./topo/libtopo/Makefile.com: -lsmbios -lc -ldevid -lipmi -lscf -lpcidb

However libpcidb is not listed as a dependency to fm (from usr/src/lib/Makefile):

fm: libexacct libipmi libzfs scsi libdevinfo libdevid libcfgadm \
libcontract libsysevent ../cmd/sgs/libelf libdladm libsff

The solution is to add libpcidb as a dependency there.

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 6578fdfad83f727b6fd5f68d4e8985b2760e0d80

commit  6578fdfad83f727b6fd5f68d4e8985b2760e0d80
Author: Jason King <jason.king@joyent.com>
Date:   2018-05-03T18:53:14.000Z

    9510 usr/src/lib/fm is missing a dependency on libpcidb
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF