Bug #9538

rcapd make install fails due to race in subdirs

Added by Toomas Soome 9 months ago. Updated 9 months ago.

Status:ClosedStart date:2018-05-15
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:cmd - userland programs
Target version:-
Difficulty:Medium Tags:

Description

usr/src/cmd/rcap/rcapd has subdirs built in parallel and every subdir is attempting to create link to isaexec. Unfortunately this can result in random order of the actions and the error:

/code/9267/usr/src/cmd/rcap/rcapd/i386
/usr/bin/rm -f /code/9267/proto/root_i386/usr/lib/rcap/i86/rcapd; /code/9267/usr
/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/926
7/proto/root_i386/usr/lib/rcap/i86 rcapd
/usr/bin/rm -f /code/9267/proto/root_i386/usr/lib/rcap/rcapd
ln /code/9267/proto/root_i386/usr/lib/isaexec /code/9267/proto/root_i386/usr/lib
/rcap/rcapd
/code/9267/usr/src/cmd/rcap/rcapd/amd64
/usr/bin/rm -f /code/9267/proto/root_i386/usr/lib/rcap/amd64/rcapd; /code/9267/u
sr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/9
267/proto/root_i386/usr/lib/rcap/amd64 rcapd
/usr/bin/rm -f /code/9267/proto/root_i386/usr/lib/rcap/rcapd
*** Error code 2 (ignored)
ln /code/9267/proto/root_i386/usr/lib/isaexec /code/9267/proto/root_i386/usr/lib/rcap/rcapd
ln: /code/9267/proto/root_i386/usr/lib/rcap/rcapd: File exists
*** Error code 2
dmake: Warning: Target `install' not remade because of errors
Current working directory /code/9267/usr/src/cmd/rcap/rcapd/amd64
*** Error code 1
The following command caused the error:
cd amd64; pwd; VERSION='illumos-gate' dmake install
dmake: Warning: Target `install' not remade because of errors

Since we only need to create one link to isaexec, the solution is to move this action out from subdirs build rules.

History

#1 Updated by Electric Monk 9 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 69d4acec15909325d6df21fec172510a50f77a8a

commit  69d4acec15909325d6df21fec172510a50f77a8a
Author: Toomas Soome <tsoome@me.com>
Date:   2018-06-01T00:07:34.000Z

    9538 rcapd make install fails due to race in subdirs
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

#2 Updated by Electric Monk 9 months ago

git commit a19d2449c7801a22d6c8370a965dab3d16c77925

commit  a19d2449c7801a22d6c8370a965dab3d16c77925
Author: Toomas Soome <tsoome@me.com>
Date:   2018-06-04T08:34:56.000Z

    9538 rcapd make install fails due to race in subdirs (fix isaexec)
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom