Project

General

Profile

Actions
Copy link

Feature #9571

closed

smbios(1M) could decode temperature probes

Added by Robert Mustacchi almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
cmd - userland programs
Start date:
2018-05-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

A system's smbios data includes temperature probes. We should consider decoding these and printing something human-readable. This is as opposed to the current value:

ID    SIZE TYPE
43    27   SMB_TYPE_TPROBE (type 28) (temperature probe)

         offset:   0 1 2 3  4 5 6 7  8 9 a b  c d e f  0123456789abcdef
            0:  1c162b00 01000080 00800080 00800080  ..+.............
         0x10:  00000000 00804c4d 373841             ......LM78A

To test this, I decoded several different smbios images and manually made sure that the bits in question lined up with what we were displaying.

Actions
Copy link
 #1

Updated by Robert Mustacchi almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed

git commit f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0

commit  f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-07-19T18:47:39.000Z

    9569 smbios(1M) could decode voltage and curent probes
    9570 smbios(1M) could decode cooling devices
    9571 smbios(1M) could decode temperature probes
    9572 smb_impl.h structs should comment corresponding type
    9573 overshifted smbios major version leads to undershifted data
    9574 smbios(1M) shouldn't print non-existant bios versions
    Reviewed by: Tim Kordas <tim.kordas@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF