Project

General

Profile

Actions

Feature #9572

closed

smb_impl.h structs should comment corresponding type

Added by Robert Mustacchi almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2018-05-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are many different structures in smb_impl.h that each represent a common structure from the SMBIOS specification. It'd be useful if we went through and commented which structure corresponded to which SMB_TYPE_XXX macro. This is just to make life easier for future developers.

Actions #1

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed

git commit f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0

commit  f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-07-19T18:47:39.000Z

    9569 smbios(1M) could decode voltage and curent probes
    9570 smbios(1M) could decode cooling devices
    9571 smbios(1M) could decode temperature probes
    9572 smb_impl.h structs should comment corresponding type
    9573 overshifted smbios major version leads to undershifted data
    9574 smbios(1M) shouldn't print non-existant bios versions
    Reviewed by: Tim Kordas <tim.kordas@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF