Project

General

Profile

Bug #9574

smbios(1M) shouldn't print non-existant bios versions

Added by Robert Mustacchi about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2018-05-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

After fixing 9573, I went through and looked for cases where we would have failed to trigger this behavior. One case was in the BIOS table. Shortly after adding this, I noticed that we were now printing the embedded controller firmware image which we previously did not due to 9573.

It turns out in one of the smbios images we had constructed, the value being printed for the version was 255.255. Reviewing the standard indicates that this means that such an embedded controller is not present. As such, if we have a major and minor of that level, we shouldn't print that information.


Related issues

Related to illumos gate - Bug #9573: overshifted smbios major version leads to undershifted dataClosed2018-05-31

Actions

History

#1

Updated by Robert Mustacchi about 2 years ago

  • Related to Bug #9573: overshifted smbios major version leads to undershifted data added
#2

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed

git commit f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0

commit  f44a1392c9d1c0ff0faf96d4eed0952a6b5cfbe0
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-07-19T18:47:39.000Z

    9569 smbios(1M) could decode voltage and curent probes
    9570 smbios(1M) could decode cooling devices
    9571 smbios(1M) could decode temperature probes
    9572 smb_impl.h structs should comment corresponding type
    9573 overshifted smbios major version leads to undershifted data
    9574 smbios(1M) shouldn't print non-existant bios versions
    Reviewed by: Tim Kordas <tim.kordas@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF