Project

General

Profile

Feature #9583

loader: remove devdesc comments and assertions

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-06-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Cleanup after devdesc rework, the comment from the original commit:

FreeBSD change: https://svnweb.freebsd.org/base?view=revision&revision=334695

Remove comments and assertions that are no longer valid after r330809.
r330809 replaced duplication of devdesc struct fields with an embedded copy of the devdesc struct, to avoid fragility. That means all the scattered comments indicating that structs must match are no longer valid. Likewise asserts that attempted to mitigate some of the old fragility.

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit e3c18722ae67aad9d682b8066dc32d5d9991489c

commit  e3c18722ae67aad9d682b8066dc32d5d9991489c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-07-09T16:33:58.000Z

    9583 loader: remove devdesc comments and assertions
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF