Project

General

Profile

Actions

Bug #9606

closed

qede: error: this 'for' clause does not guard

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2018-06-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Error found by gcc 7 build:

    ../../common/io/qede/579xx/drivers/ecore/ecore_dbg_fw_funcs.c: In function 'ecore_dbg_bus_add_constraint':
    ../../common/io/qede/579xx/drivers/ecore/ecore_dbg_fw_funcs.c:5448:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
       for (width = 0;
       ^~~
    ../../common/io/qede/579xx/drivers/ecore/ecore_dbg_fw_funcs.c:5451:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
        if (data_mask)
        ^~
    cc1: all warnings being treated as errors

Indentation error.

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 77b62fe435d195b5a58f123e6c5ec9c9dffdc877

commit  77b62fe435d195b5a58f123e6c5ec9c9dffdc877
Author: Toomas Soome <tsoome@me.com>
Date:   2018-07-30T17:29:43.000Z

    9606 qede: error: this 'for' clause does not guard
    Reviewed by: Andy Fiddaman <af@citrus-it.net>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Ken Mays <kmays2000@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF