Bug #9638

libc/port/fp/sigfpe.c: this statement may fall through

Added by Toomas Soome 4 months ago. Updated 2 months ago.

Status:ClosedStart date:2018-07-03
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:lib - userland libraries
Target version:-
Difficulty:Bite-size Tags:

Description

Build issue with gcc 8:

    ../port/fp/sigfpe.c: In function '_sigfpe_master':
    ../port/fp/sigfpe.c:137:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (code) {
       ^~~~~~
    ../port/fp/sigfpe.c:156:2: note: here
      case ((intptr_t)(SIGFPE_ABORT)):
      ^~~~
    cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk 2 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 72dc11568f48cd37cf8182a82d9cb55b22d7c805

commit  72dc11568f48cd37cf8182a82d9cb55b22d7c805
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-07T17:42:54.000Z

    9638 libc/port/fp/sigfpe.c: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom