Project

General

Profile

Actions
Copy link

Bug #9643

closed

PKCS#11 tests should not use CRYPTO_INVALID_SESSION

Added by Jason King about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jason King
Category:
tests
Start date:
2018-07-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Upstream of Joyent OS-6600.

Currently usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c uses the kernel crypto API macro CRYPTO_INVALID_SESSION to identify an invalid PKCS#11 session handle. This is defined to -1, however CK_INVALID_HANDLE (which is the PKCS#11 value for any invalid handle – session, object, etc) is defined to 0. This mismatch causes much sadness for any PKCS#11 failures.

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2cf2b01e17654840a521746eefea832fb41b79bd

commit  2cf2b01e17654840a521746eefea832fb41b79bd
Author: Jason King <jason.king@joyent.com>
Date:   2018-07-11T17:18:10.000Z

    9643 PKCS#11 tests should not use CRYPTO_INVALID_SESSION
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF